Optimize SceneTreeEditor::_update_node_tooltip()
#97777
Open
+76
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYF233333
force-pushed
the
stringbuilder
branch
from
f425cf2
to
fca248d
Compare
YYF233333
force-pushed
the
stringbuilder
branch
from
fca248d
to
c1e507d
Compare
|
restore the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split to 2 commit to make review easier.
Make
SceneTreeEditor::_update_node_tooltip()reuse the string build buffer instead of alloc buffer/tmp string everytime.1st commit: make
StringBuildersuitable for multi time use by reusing the buffer inas_string()method.2nd commit: use a static
StringBuilderfor string concat.performance:
bench with ManyNodes.zip, test time to open
ManyNodes.tscn(100k nodes).Master branch: (about 9.5s)
This PR: (about 9.0s)
This PR without changes applied to
StringBuilder: (about 9.5s)