-
-
Notifications
You must be signed in to change notification settings - Fork 20.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ColorPicker
virtual keyboard popup on mobile
#97807
base: master
Are you sure you want to change the base?
Fix ColorPicker
virtual keyboard popup on mobile
#97807
Conversation
c912f00
to
6f795f8
Compare
It looks good but I don't know if we should return from |
@WhalesState Isn't this the current behaviour, virtual keyboard does not appear if physical keyboard is connected. |
There was no way to check for physical keyboards before, it was recently merged so it always show the virtual keyboard on android and ios by default. |
That's why i have applied a hack for this, since focusing any |
No, virtual keyboard doesn't appear if physical kb is connected even before that PR . This was used internally just wasn't exposed. |
There's an option on android |
I just checked in two different devices and it was turned off in Motorola and turned on in Xiaomi, both are default. But that is out of scope of this PR. |
ColorPicker
virtual keyboard popup on mobile
6f795f8
to
953c625
Compare
953c625
to
abbf90a
Compare
This PR fixes auto popup of virtual keyboard when colorPickerButton is pressed on mobile devices.
Fixes #88235