Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!(v0): update v0 for the upcoming ckb 2023 hardfork #1084

Merged
merged 10 commits into from
Oct 12, 2023

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Jul 18, 2023

Updated rust, ckb deps, ckb-vm, ckb-sdk and ckb-cli. The ckb builtin indexer is required (and the standalone indexer is no longer supported).

  • A new image would need to be built. It should have a newer ckb-cli.
    • test: use the new image to run a Godwoken v0 readonly-node and sync to TIP to make sure the new image is OK
  • Kicker will also need some small updates.

@Flouse
Copy link
Collaborator

Flouse commented Jul 18, 2023

The ckb builtin indexer is required and the standalone ckb-indexer is no longer supported in the next version of Godwoken v0.
cc @Simon-Tl

@Flouse Flouse added dependencies Pull requests that update a dependency file v0 labels Jul 18, 2023
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@blckngm
Copy link
Contributor Author

blckngm commented Jul 19, 2023

I've tested this with godwokenrises/godwoken-kicker@c65db31 and v0 works fine.

Now we just need to add a github workflow to build and push the image.

@Flouse
Copy link
Collaborator

Flouse commented Jul 19, 2023

Dockerfile Outdated Show resolved Hide resolved
@Flouse Flouse changed the title chore!(v0): update v0 for upcoming ckb 2023 hardfork chore!(v0): update v0 for the upcoming ckb 2023 hardfork Jul 21, 2023
@jjyr jjyr requested a review from Flouse September 19, 2023 05:48
@jjyr
Copy link
Collaborator

jjyr commented Sep 19, 2023

Please fix CI @blckngm

@blckngm
Copy link
Contributor Author

blckngm commented Sep 19, 2023

We should update to ckb 0.111.0 and ckb-sdk 3.0. Will update later.

@blckngm blckngm marked this pull request as ready for review October 12, 2023 06:01
@Flouse Flouse merged commit abb606b into godwokenrises:0.10-rc Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file v0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants