Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docusaurus preparations #2703
docusaurus preparations #2703
Changes from 10 commits
f45e21e
fa871a3
d85c8d2
67fef99
2971450
a6f4b27
c1bd70d
cc5cd54
4146b8d
017a25c
e937d9a
1bf65b3
88db22f
fdb7c34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix security and reliability issues in file synchronization
Several critical issues need to be addressed:
Apply these changes:
📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 23-23: For loops over find output are fragile. Use find -exec or a while read loop.
(SC2044)
[warning] 27-27: Quote this to prevent word splitting.
(SC2046)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve file handling safety and portability
The current implementation has several issues with special characters in filenames and portability. Additionally, Shellcheck warns about fragile find usage.
This change:
📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 21-21: For loops over find output are fragile. Use find -exec or a while read loop.
(SC2044)
[warning] 23-23: Quote this to prevent word splitting.
(SC2046)