implement TimestampFromV7 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #123
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 498 513 +15
=========================================
+ Hits 498 513 +15
☔ View full report in Codecov by Sentry. |
|
Thank you dropwhile! |
|
Thanks a ton for the contribution @dropwhile :) Gonna merge this and kick it out later today. |
|
Hi there! Please advise when there will be a new version with this feature? |
jimgolfgti
reviewed
Feb 8, 2024
| // releases until the spec is final. | ||
| func TimestampFromV7(u UUID) (Timestamp, error) { | ||
| if u.Version() != 7 { | ||
| return 0, fmt.Errorf("uuid: %s is version %d, not version 6", u, u.Version()) |
There was a problem hiding this comment.
The comment here is off by one. Should read
return 0, fmt.Errorf("uuid: %s is version %d, not version 7", u, u.Version())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #123