-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Performance of delete
Command with Concurrency
#80
base: main
Are you sure you want to change the base?
Conversation
project delete
Command with Concurrency
project delete
Command with Concurrency delete
Command with Concurrency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Could you add multiple selection in the TUI too? And can you combine the commits into one for a cleaner history?
Currently working on TUI multiple selection. Will squash the commits. |
I am planning to add the multiple TUI selection as a base component in separate PR. |
This PR is ready for review @Vad1mo |
ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should rebase with new changes
handles concurrent deletion of projects, registries and users Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #79
Description:
This PR enhances the performance of the
harbor project delete
command by introducing concurrency to handle multiple project deletions in parallel. The changes ensure that the command is more efficient, especially when dealing with multiple projects.Changes:
runDeleteProject
concurrently for each project specified in the command arguments.Error Handling:
Benefits:
Testing:
Example Usage: