Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced query.Sorting with query.Sorts #20723

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

replaced query.Sorting with query.Sorts #20723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc70ebb
replaced query.Sorting with query.Sorts
Its-Maniaco Jul 10, 2024
62e31ad
removed query.sorting
Its-Maniaco Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/pkg/scan/dao/scanner/registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,6 @@ func ListRegistrations(ctx context.Context, query *q.Query) ([]*Registration, er
if err != nil {
return nil, err
}

// Order the list
if query.Sorting != "" {
qs = qs.OrderBy(query.Sorting)
} else {
qs = qs.OrderBy("-is_default", "-create_time")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we need to keep this line to ensure backward compatibility without introducing inconsistent results from previous versions, because the common query logic processor will not handle this special case.

}

l := make([]*Registration, 0)
_, err = qs.All(&l)

Expand Down