Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally enable ipv6 listen directives in nginx configs #20880

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

msc-xdev
Copy link

@msc-xdev msc-xdev commented Aug 27, 2024

Enable ipv6 according to config file

Harbor has added the ability to configure external ipv6 since a3e1b1e, but has only added it to the https-side of the proxy.
Therefore a curl -LI6 http://my-harbor.tld returns:
curl: (7) Failed to connect to my-harbor.tld port 80 after 6 ms: Couldn't connect to server

This PR tries to fix that by adding it to the other listen directives in the nginx configs.

Related #11399

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@msc-xdev
Copy link
Author

I need to say that I added the ipv6 network manually in my docker-compose.yml so that the nginx sees the correct ipv6 and can log it correctly.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (c8c11b4) to head (5ef2853).
Report is 268 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20880      +/-   ##
==========================================
+ Coverage   45.36%   46.20%   +0.83%     
==========================================
  Files         244      247       +3     
  Lines       13333    13782     +449     
  Branches     2719     2847     +128     
==========================================
+ Hits         6049     6368     +319     
- Misses       6983     7084     +101     
- Partials      301      330      +29     
Flag Coverage Δ
unittests 46.20% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants