Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove robotV1 from code base (#20958) #20991

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sgaist
Copy link

@sgaist sgaist commented Oct 1, 2024

This PR remove the deprecated robotV1 code and endpoint.

It was deprecated in 2.4.0.

Issue being fixed

Fixes #20958

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@sgaist sgaist requested a review from a team as a code owner October 1, 2024 21:05
@sgaist
Copy link
Author

sgaist commented Oct 1, 2024

I am unsure which label should be applied since it's the removal of a deprecated API. I would guess release-note/breaking-change is the more suited.

@wy65701436
Copy link
Contributor

@sgaist please help to resolve the conflict, thanks.

@wy65701436 wy65701436 added release-note/update Update or Fix release-note/deprecation Harbor Deprecation MUST need to be in release notes and removed release-note/update Update or Fix labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (c8c11b4) to head (c9d630d).
Report is 309 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20991       +/-   ##
===========================================
+ Coverage   45.36%   65.98%   +20.61%     
===========================================
  Files         244     1048      +804     
  Lines       13333   113554   +100221     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    74931    +68882     
- Misses       6983    34485    +27502     
- Partials      301     4138     +3837     
Flag Coverage Δ
unittests 65.98% <ø> (+20.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/server/v2.0/handler/handler.go 0.00% <ø> (ø)

... and 1286 files with indirect coverage changes

It was deprecated in 2.4.0.

Signed-off-by: Samuel Gaist <[email protected]>
@sgaist
Copy link
Author

sgaist commented Oct 11, 2024

@sgaist please help to resolve the conflict, thanks.

Solved !

@wy65701436
Copy link
Contributor

since, we're in the release cycle of v2.12. I will merge it after we branch v2.12, thanks.

@sgaist
Copy link
Author

sgaist commented Oct 12, 2024

@wy65701436 Sure thing !

In between, would you be so kind and add the hacktoberfest-accepted label to the PR please ?

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate/2.13.0 release-note/deprecation Harbor Deprecation MUST need to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the source code of robotV1
4 participants