Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian language support #21083

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sergey-akhmineev
Copy link

@sergey-akhmineev sergey-akhmineev commented Oct 24, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Added support for the Russian language, including translations for UI elements and configuration files.

Issue being fixed

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/new-feature"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Sergey Akhmineev <[email protected]>
@wy65701436 wy65701436 added help wanted The issues that is valid but needs help from community area/i18n Related to Translation changes. labels Oct 24, 2024
@OrlinVasilev
Copy link
Member

OrlinVasilev commented Oct 24, 2024

Hi @sergey-akhmineev great stuff but we would need another Russian speaker to verify the translation if you don't mind
and also we would love to have a long term support on the translation :)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (c8c11b4) to head (eb849e7).
Report is 343 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21083       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.71%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75768    +69719     
- Misses       6983    34737    +27754     
- Partials      301     4144     +3843     
Flag Coverage Δ
unittests 66.08% <ø> (+20.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@sergey-akhmineev
Copy link
Author

Hi @OrlinVasilev of course I don't mind, I understand everything. If you really want to, of course I will continue long term translation support.

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Dec 31, 2024
@sias32
Copy link

sias32 commented Jan 27, 2025

When to expect?

@github-actions github-actions bot removed the Stale label Jan 28, 2025
@OrlinVasilev
Copy link
Member

Hi @sergey-akhmineev did you manage to find someone else to review it ? if not I will address that to the community again!

@OrlinVasilev
Copy link
Member

OrlinVasilev commented Jan 28, 2025

@Kalmanq, @vladrunk, @Nikemaks, @kosmos2uh, @mykyta-yaremenko, @msaichuk, @LexGlu, @yevhenkizin, @mykhailo-samus, and @zorc why did you voted 👎 on my request: #21083 (comment)
Is there anything that bothers you in the translation ? please comment! Thank you!

Copy link

@sias32 sias32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched half of it and made a couple of comments

src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/ru-ru-lang.json Outdated Show resolved Hide resolved
@OrlinVasilev
Copy link
Member

Thank you @sias32 great stuff :) @sergey-akhmineev ^^

OrlinVasilev and others added 2 commits January 29, 2025 11:33
Made edits to the translation based on comments

Signed-off-by: Sergey <[email protected]>
@sergey-akhmineev
Copy link
Author

@sias32 , @OrlinVasilev I've made the suggested changes to the translation, and I'm currently re-checking the translation. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. help wanted The issues that is valid but needs help from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants