Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vmware with goharbor in README #21626

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Feb 12, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • Replace links pointing to vmware/harbor which then redirects back to goharbor/harbor

Why?

if vmware creates repo named harbor. this redirection will break and this link will not be redirected back to goharbor/harbor.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/docs"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner February 12, 2025 22:53
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Feb 13, 2025
@Vad1mo Vad1mo enabled auto-merge (squash) February 13, 2025 11:22
@Vad1mo Vad1mo merged commit cc96643 into goharbor:main Feb 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants