Iseyer/replicate tags

[ianseyer]

Currently, harbor does not replicate image tags for event-based replications. Instead, if a new tag is pushed, a replication event is not fired.

This issue is easily replicated:

• push an image with a tag
• push the same image with a new tag
• watch replication not happen

There should be followup work to correct the issue of webhooks not being fired for tags being created.

Issue being fixed

Fixes #21623

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[ianseyer]

@Vad1mo @wy65701436 @reasonerjt

if you would be so kind as to review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (c8c11b4) to head (634b662).
Report is 392 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21660      +/-   ##
==========================================
+ Coverage   45.36%   46.30%   +0.93%     
==========================================
  Files         244      249       +5     
  Lines       13333    14047     +714     
  Branches     2719     2897     +178     
==========================================
+ Hits         6049     6504     +455     
- Misses       6983     7199     +216     
- Partials      301      344      +43     

Flag	Coverage Δ
unittests	46.30% <ø> (+0.93%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

[Vad1mo]

On the first glance it looks good, we need to give it an end-end try and see how it performs.

do we need to update the test cases?

[ianseyer]

I have identified a bug. This PR results in two events being fired for the first tag push of a new artifact:

Any ideas on how to avoid firing the tag event on first push? The tag event in that instance is handled by artifact.Ensure

I am not sure why this isn't caught by https://github.com/goharbor/harbor/blob/main/src/controller/tag/controller.go#L90

In the immediate sense, I think this is harmless behavior, but I did want to note it.