-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use short token for code highlighting #5350
base: master
Are you sure you want to change the base?
Conversation
69c505e
to
32922c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Looks like something's off here
32922c5
to
8036447
Compare
I don't know enough about RsT to merge this. I'm mostly concerned if this new flag will somehow break in some RsT versions. @anthonyfok any input? others? |
Looks like there's now a merge conflict because the location of this code changed. If I were to rebase this PR, would that be somethign that could merged, or are there larger concerns? |
I've rebased this. It's definitely safe |
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help. |
This is still valid. Let me know if I can help explain anything |
@stephenfin looks like there's a merge conflict to resolve here. |
As I said, I don't know enough about this to review this. |
Signed-off-by: Stephen Finucane <[email protected]> Closes: gohugoio#5349
37685f7
to
9cfdd9c
Compare
Closes: #5349
As noted in #5349,
rst2html
can generate HTML with short or long form class names for syntax highlighting. Pygments (via thepygmentize
command) seems to generate short form by default without any way to switch this. This means most/any stylesheets for code provided with various themes won't work when using rST output. This can easily be fixed by providing the--syntax-highlight=short
flag torst2html
.