-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow connection to multiple address simultaneously #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajatprabha
force-pushed
the
COURIER-1542
branch
from
August 22, 2023 09:41
1761066
to
a6da169
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #31 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 29 32 +3
Lines 537 651 +114
==========================================
+ Hits 537 651 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ajatprabha
force-pushed
the
COURIER-1542
branch
from
August 22, 2023 10:34
6b4fad6
to
3ec77be
Compare
ajatprabha
force-pushed
the
COURIER-1542
branch
from
August 22, 2023 10:49
3ec77be
to
8a507fd
Compare
ajatprabha
force-pushed
the
COURIER-1542
branch
2 times, most recently
from
August 24, 2023 12:08
17a3ada
to
07bf371
Compare
ajatprabha
changed the title
Allow connection to multiple address simultaneously
Draft: Allow connection to multiple address simultaneously
Aug 24, 2023
ajatprabha
force-pushed
the
COURIER-1542
branch
from
August 24, 2023 12:43
07bf371
to
8df50bf
Compare
dhruvjain99
requested changes
Aug 31, 2023
ajatprabha
force-pushed
the
COURIER-1542
branch
from
September 1, 2023 10:49
db39e9d
to
9f89411
Compare
ajatprabha
force-pushed
the
COURIER-1542
branch
from
September 4, 2023 12:16
063977c
to
1143dcf
Compare
dhruvjain99
reviewed
Sep 5, 2023
dhruvjain99
approved these changes
Sep 5, 2023
ajatprabha
changed the title
Draft: Allow connection to multiple address simultaneously
Allow connection to multiple address simultaneously
Sep 5, 2023
ajatprabha
force-pushed
the
COURIER-1542
branch
from
September 12, 2023 09:31
d457a7e
to
df5dca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also aims to handle resubscribe scenarios for new address updates.