Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connection to multiple address simultaneously #31

Merged
merged 24 commits into from
Oct 1, 2023
Merged

Conversation

ajatprabha
Copy link
Member

This PR also aims to handle resubscribe scenarios for new address updates.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #31 (962ecbb) into main (5f1f085) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##              main       #31    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           29        32     +3     
  Lines          537       651   +114     
==========================================
+ Hits           537       651   +114     
Files Coverage Δ
client.go 100.00% <100.00%> (ø)
client_options.go 100.00% <100.00%> (ø)
client_publish.go 100.00% <100.00%> (ø)
client_resolver.go 100.00% <100.00%> (ø)
client_subscribe.go 100.00% <100.00%> (ø)
client_unsubscribe.go 100.00% <100.00%> (ø)
exec.go 100.00% <100.00%> (ø)
log.go 100.00% <100.00%> (ø)
slog/log.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajatprabha ajatprabha force-pushed the COURIER-1542 branch 2 times, most recently from 17a3ada to 07bf371 Compare August 24, 2023 12:08
@ajatprabha ajatprabha changed the title Allow connection to multiple address simultaneously Draft: Allow connection to multiple address simultaneously Aug 24, 2023
client_options.go Outdated Show resolved Hide resolved
client_options.go Show resolved Hide resolved
client_resolver.go Outdated Show resolved Hide resolved
client_resolver.go Outdated Show resolved Hide resolved
client_resolver.go Show resolved Hide resolved
client_options.go Outdated Show resolved Hide resolved
client_resolver.go Outdated Show resolved Hide resolved
@dhruvjain99 dhruvjain99 self-requested a review September 5, 2023 06:10
@ajatprabha ajatprabha changed the title Draft: Allow connection to multiple address simultaneously Allow connection to multiple address simultaneously Sep 5, 2023
@ajatprabha ajatprabha merged commit 56a982e into main Oct 1, 2023
3 checks passed
@ajatprabha ajatprabha deleted the COURIER-1542 branch October 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants