[Rajat] Add Github client to fetch latest release of proctor #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RajatVaryani wrapping the github client inside a struct is a good enough approach. see if you can reverse engineer the http call and mock it, else leave the testing of github client code. Just inject the wrapper struct, mock it in application code's tests and you're good to go. |
jensoncs
suggested changes
Mar 11, 2019
jensoncs
suggested changes
Mar 11, 2019
cmd/version/github/client.go
Outdated
| return &client{github.NewClient(nil)} | ||
| } | ||
|
|
||
| func (gc *client) LatestRelease(owner, repository string) (*github.RepositoryRelease, error) { |
There was a problem hiding this comment.
Instead of returning '*github.RepositoryRelease' in the LatestRelease function, you can return string directly. Then in the caller you can directly use the value instead of '*release.TagName' in version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR references #55. I am using a mature github client. The only pitfall with the library is that mocking is not easy as the github client does not expose any interfaces. This is a draft PR suggesting that. @olttwa How should we go forward with this?