Skip to content

Commit

Permalink
remove os.Root TODO
Browse files Browse the repository at this point in the history
I looked into it and os.Root does not have all the operations we need.
Specifically, as of Go 1.24, we need Readlink and Symlink.
But even then, calls like unix.Mknod will likely never be part of os.Root.
  • Loading branch information
stapelberg committed Feb 24, 2025
1 parent 244375a commit ab953f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/nofollow/nofollow_others.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
package nofollow

// Maybe resolves to unix.O_NOFOLLOW on unix systems,
// 0 on other platforms. TODO(go1.24): use os.Root.
// 0 on other platforms.
const Maybe = 0
2 changes: 1 addition & 1 deletion internal/nofollow/nofollow_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ package nofollow
import "golang.org/x/sys/unix"

// Maybe resolves to unix.O_NOFOLLOW on unix systems,
// 0 on other platforms. TODO(go1.24): use os.Root.
// 0 on other platforms.
const Maybe = unix.O_NOFOLLOW

0 comments on commit ab953f0

Please sign in to comment.