Return nil in NewHMAC if HMAC doesn't support the hash function #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails because |
|
#160 has merged, not sure how you re-trigger CI here though |
I've now merged |
dagood
reviewed
Sep 4, 2024
karianna
approved these changes
Sep 5, 2024
dagood
approved these changes
Sep 6, 2024
|
@qmuntal will need a rebase now |
Co-authored-by: Davis Goodin <[email protected]>
mertakman
pushed a commit
to mertakman/openssl
that referenced
this pull request
Sep 10, 2024
…ng-fips#159) * return nil in NewHMAC if HMAC doesn't support the hash function * Update hmac.go Co-authored-by: Davis Goodin <[email protected]> --------- Co-authored-by: Davis Goodin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check in the OpenSSL 3
NewHMACcode path to prove that the fetched HMAC can be used with the given hash function. If that's not possible, thenNewHMACwill returnnil. Note that this was already the case if the hash function was not supported as a stand-alone algorithm.Fixes #153.