Don't set caller information in CRYPTO_[malloc,free] #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
karianna,
derekparker,
dagood,
mertakman and
gdams
gdams
approved these changes
Feb 21, 2025
mertakman
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CRYPTO_mallocandCRYPTO_freefile and line parameters were used in OpenSSL 1 to report memory leaks when calling CRYPTO_mem_leaks.OpenSSL 3 removed support for the built-in memory leak detections, making
CRYPTO_mem_leaksno-op. The recommended way of detecting memory leaks is using LLVM address sanitizers or Valgrind.We have never used
CRYPTO_mem_leaks, and alrady use the recommended way when testing OpenSSL 1, so there is no need to fill the file and line info when calling OpenSSL memory functions. This avoids a call to runtime.Caller, which is strange to see in the middle of a cryptographic function.