Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rate limiter bug #17

Closed
wants to merge 1 commit into from
Closed

fix rate limiter bug #17

wants to merge 1 commit into from

Conversation

zwkno1
Copy link

@zwkno1 zwkno1 commented Mar 31, 2021

i write this code to test rate limiter:

func TestRateLimit(t *testing.T) {
	limiter := rate.NewLimiter(5, 5)

	wait := sync.WaitGroup{}

	var count uint64
	startTime := time.Now().Unix()

	go func() {
		for {
			elapsed := time.Now().Unix() - startTime
			var qps uint64
			if elapsed > 0 {
				qps = atomic.LoadUint64(&count) / uint64(elapsed)
			}
			t.Log("qps: ", qps)

			time.Sleep(time.Second)
		}
	}()

	for i := 0; i < 100000; i++ {
		wait.Add(1)
		go func() {
			for {
				if limiter.Allow() {
					atomic.AddUint64(&count, 1)
				}
				time.Sleep(time.Microsecond * 10)
			}
			wait.Done()
		}()
	}
	wait.Wait()
}

the test outputs:
TestRateLimit: ratelimiter_test.go:32: qps: 0
TestRateLimit: ratelimiter_test.go:32: qps: 91541
TestRateLimit: ratelimiter_test.go:32: qps: 199775
TestRateLimit: ratelimiter_test.go:32: qps: 228304
TestRateLimit: ratelimiter_test.go:32: qps: 246161
TestRateLimit: ratelimiter_test.go:32: qps: 260489

there is a bug caused by timestamp before last

@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: bf4933f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/time/+/306189 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/306189.
After addressing review feedback, remember to publish your drafts!

@zwkno1 zwkno1 closed this by deleting the head repository Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants