Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a long time has passed since a previous call to the rate limiter,
we can overflow when calculating how many new tokens are available.
To prevent that, we calculated a maximum elapsed amount.
When we used maxElapseed, we ended up converting a duration into tokens
and then back. This operation was lossy, so we took pains to increase
the precision of the conversion in tokensFromDuration.
An easier fix is to avoid the round trip entirely.
We know the max number of new tokens we should add; cap it directly.
This lets us use the original, simpler tokensFromDuration.
While we're here, tweak durationFromTokens for clarity.
Updates #34861