Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rate: fix truncated seconds in tokensFromDuration #8

Closed
wants to merge 2 commits into from
Closed

rate: fix truncated seconds in tokensFromDuration #8

wants to merge 2 commits into from

Conversation

changkun
Copy link
Member

This CL fixes a truncated variable which may cause an incorrect result.

Fix golang/go#34861

@gopherbot
Copy link
Contributor

This PR (HEAD: e9c4c03) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/time/+/200917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Eric Lagergren:

Patch Set 1:

Relates to https://go-review.googlesource.com/c/time/+/200900


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1

(1 comment)

R=sameer


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=7bd81c57


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ee5d930) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/time/+/200917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Changkun Ou:

Patch Set 2: Code-Review+1

(1 comment)

Patch Set 1: Run-TryBot+1

(1 comment)

R=sameer


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Sameer Ajmani:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/200917.
After addressing review feedback, remember to publish your drafts!

@changkun changkun closed this Oct 25, 2019
@changkun changkun deleted the issue34861 branch October 25, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/time: when rate is 0.7692307692307693 (10/13), Allow() returns false
3 participants