Skip to content

Commit

Permalink
all: fix broken image links
Browse files Browse the repository at this point in the history
Some links were broken due to a contributor's name change.

Change-Id: Ibb766de3aa9c9f89cca81d3d6e26dddc4d7893cf
Reviewed-on: https://go-review.googlesource.com/c/wiki/+/638298
Reviewed-by: Ian Lance Taylor <[email protected]>
Commit-Queue: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
  • Loading branch information
hongalex authored and gopherbot committed Dec 25, 2024
1 parent a5897f4 commit 7085acd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ my-repo
|-- go.mod
`-- vub
```
![Fig. A top-level module's path is a prefix of another module's path.](https://github.com/jadekler/module-testing/blob/master/imagery/multi_module_repo.png)
![Fig. A top-level module's path is a prefix of another module's path.](https://github.com/jeanbza/module-testing/blob/master/imagery/multi_module_repo.png)

_Fig. A top-level module's path is a prefix of another module's path._

Expand Down
2 changes: 1 addition & 1 deletion Projects.md
Original file line number Diff line number Diff line change
Expand Up @@ -1797,7 +1797,7 @@ See also [SQLDrivers page](SQLDrivers).
* [SuperSaaS API Client](https://github.com/SuperSaaS/supersaas-go-api-client) - HTTP client library for the supersaas.com scheduling/bookings/appointments API
* [Tideland golib](https://github.com/tideland/golib) - Web package for REST request handling
* [Vantaa](https://github.com/nathandao/vantaa) - A modular blogging API engine written in Go, Neo4j and Polymer.
* [websiteskeleton](https://github.com/jadekler/git-go-websiteskeleton) - Simple net/http website skeleton
* [websiteskeleton](https://github.com/jeanbza/git-go-websiteskeleton) - Simple net/http website skeleton
* [webtf](http://code.google.com/p/webtf/) - Web app to graphical visualization of twitter timelines using the HTML5
* [Wikifeat](https://github.com/rhinoman/wikifeat) - Extensible wiki system using CouchDB written in Golang
* [jweb](https://gitlab.com/drjele-go/jweb) - A Symfony(https://symfony.com/) inspired framework, written in Go
Expand Down
10 changes: 5 additions & 5 deletions Resolving-Problems-From-Modified-Module-Path.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ This is all well and good, and should satisfy most user's problems.

However, there is one situation that ends up being quite a bit more involved: when there are cycles in the module dependency graph. Consider this module dependency graph:

![Module Dependency Graph With A Cycle](https://github.com/jadekler/module-testing/blob/master/imagery/Mod%20Graph%20With%20Cycle.jpg)
![Module Dependency Graph With A Cycle](https://github.com/jeanbza/module-testing/blob/master/imagery/Mod%20Graph%20With%20Cycle.jpg)

And, let's imagine that `some/lib` used to depend on `github.com/golang/lint`.

Expand All @@ -99,7 +99,7 @@ some/[email protected] github.com/golang/[email protected]

Visualized with [golang.org/x/exp/cmd/modgraphviz](https://pkg.go.dev/golang.org/x/exp/cmd/modgraphviz):

![A Module Dependency Graph With Trailing History](https://github.com/jadekler/module-testing/blob/master/imagery/graph1.png)
![A Module Dependency Graph With Trailing History](https://github.com/jeanbza/module-testing/blob/master/imagery/graph1.png)

Here we see that even though the last several versions of `some/lib` correctly depend on `golang.org/x/lint`, the fact that `some/lib` and `some-other/lib` share a cycle mean that there's very likely to be a path far back in time.

Expand All @@ -118,7 +118,7 @@ some/[email protected] golang.org/x/[email protected]
some-other/[email protected] some/[email protected]
```

![A Module Dependency Graph Without Trailing History](https://github.com/jadekler/module-testing/blob/master/imagery/graph2.png)
![A Module Dependency Graph Without Trailing History](https://github.com/jeanbza/module-testing/blob/master/imagery/graph2.png)

Since `some/lib` and `some-other/lib` depend on each other at the same version, there's no path backwards in time to a point where `github.com/golang/lint` is provided.

Expand Down Expand Up @@ -161,9 +161,9 @@ Note that between steps 5.b and 5.d, users are broken: a version of `some/lib` h

This example explained the process for removing historical trails when there exists a cycle involving two packages in a graph, but what about if there are cycles involving more packages? For example, consider the following graphs:

![Module Dependency Graph With Four Related Cycles](https://github.com/jadekler/module-testing/blob/master/imagery/Mod%20Graph%20With%204%20Cycle_%20A.jpg)
![Module Dependency Graph With Four Related Cycles](https://github.com/jeanbza/module-testing/blob/master/imagery/Mod%20Graph%20With%204%20Cycle_%20A.jpg)

![Module Dependency Graph With One Four Vertex Cycle](https://github.com/jadekler/module-testing/blob/master/imagery/Mod%20Graph%20With%204%20Cycle_%20B.jpg)
![Module Dependency Graph With One Four Vertex Cycle](https://github.com/jeanbza/module-testing/blob/master/imagery/Mod%20Graph%20With%204%20Cycle_%20B.jpg)

Each of these graphs involve cycles (the latter example) or interconnected modules (the former example) involving four modules, instead of the simple two module example we saw earlier. The process is largely the same, though, but this time in step 3 and 5 we're going to bump all four modules to non-existent future versions of each other, and similarly in steps 4 and 6 we're going to test all four modules, and in step 7 fix the go.sum of all four modules.

Expand Down

0 comments on commit 7085acd

Please sign in to comment.