Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor fixes to install-misspell.sh and typo in readme #26

Merged
merged 4 commits into from
Jan 26, 2025
Merged

chore: minor fixes to install-misspell.sh and typo in readme #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f33e1a9
README: seprated->separated
jessp01 Jan 26, 2025
9ff56d7
Using "sqlite3" here makes sense as it refers to the SQLite3 CLI client.
jessp01 Jan 26, 2025
be4c225
Update README.md
jessp01 Jan 26, 2025
b6f49b7
Merge branch 'master' into fix-typo-minor-fixes-to-install-misspell.sh
jessp01 Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ It doesn't work well for Python and Bash.
<a name="csv"></a>
### How Can I Get CSV Output?

Using `-f csv`, the output is standard comma-seprated values with headers in the first row.
Using `-f csv`, the output is standard comma-separated values with headers in the first row.

```console
$ misspell -f csv *
Expand Down Expand Up @@ -244,7 +244,7 @@ $ sqlite3 -init /tmp/misspell.sql :memory: 'select count(*) from misspell'
1
```

With some tricks you can directly pipe output to sqlite3 by using `-init /dev/stdin`:
With some tricks you can directly pipe output to `sqlite3` by using `-init /dev/stdin`:

```
misspell -f sqlite * | sqlite3 -init /dev/stdin -column -cmd '.width 60 15' ':memory' \
Expand Down Expand Up @@ -307,7 +307,7 @@ They all work but had problems that prevented me from using them at scale:

* slow, all of the above check one misspelling at a time (i.e. linear) using regexps
* not MIT/Apache2 licensed (or equivalent)
* have dependencies that don't work for me (python3, bash, linux sed, etc.)
* have dependencies that don't work for me (Python3, Bash, GNU sed, etc.)
* don't understand American vs. British English and sometimes makes unwelcome "corrections"

That said, they might be perfect for you and many have more features than this project!
Expand Down
12 changes: 6 additions & 6 deletions install-misspell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ untar() {
;;
esac
}

http_download_curl() {
local_file=$1
source_url=$2
Expand All @@ -249,14 +250,12 @@ http_download_curl() {
curl -sL -o "$local_file" "$source_url"
else
curl -sL -H "$header" -o "$local_file" "$source_url"

nf=$(cat "$local_file" | jq -r '.error // ""')
if [ ! -z "$nf" ]; then
nf=$(jq -r '.error // ""' "$local_file")
if [ -n "$nf" ]; then
log_debug "http_download_curl received an error: $nf"
return 1
fi
fi

return 0
fi

Expand All @@ -271,6 +270,7 @@ http_download_curl() {
fi
return 0
}

http_download_wget() {
local_file=$1
source_url=$2
Expand Down Expand Up @@ -357,8 +357,8 @@ EOF

PROJECT_NAME="misspell"
OWNER=golangci
REPO="misspell"
BINARY=misspell
REPO=$PROJECT_NAME
BINARY=$PROJECT_NAME
FORMAT=tar.gz
OS=$(uname_os)
ARCH=$(uname_arch)
Expand Down
Loading