Add worker fork functionality in golem host #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
reviewed
Jan 21, 2025
| @@ -0,0 +1,12 @@ | |||
| package golem:[email protected]; | |||
There was a problem hiding this comment.
This is not how we should do it (I did a similar thing before and had to undo) because it is not (always) possible to refer to multiple versions of the same package. For example not possible with cargo-component.
On the other hand, there is semantic versioning support in wasmtime so we can do additions to the existing interfaces by increasong the minor version number. (I did not know this when I created golem:[email protected] next to golem:[email protected] and because of that we have a lot of code duplication now).
So, do the following:
- increase the version to
1.1.1ingolem-host.1.1.wit - add the new function there
This was referenced Jan 22, 2025
vigoo
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.