Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support canceling scheduled invocations #48

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Support canceling scheduled invocations #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab3366e
support canceling scheduled invocations
mschuwalow Feb 9, 2025
5ea21f3
bump versions
mschuwalow Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wit/deps/golem-1.x/golem-host.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package golem:[email protected].3;
package golem:[email protected].4;

/// The Golem host API provides low level access to Golem specific features such as promises and control over
/// the durability and transactional guarantees the executor provides.
interface host {
use golem:rpc/[email protected].2.{uri, wit-value};
use golem:rpc/[email protected].3.{uri, wit-value};
use wasi:clocks/[email protected].{duration};

/// An index into the persistent log storing all performed operations of a worker
Expand Down
4 changes: 2 additions & 2 deletions wit/deps/golem-1.x/golem-oplog-processor.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package golem:[email protected].3;
package golem:[email protected].4;

interface oplog-processor {
use wasi:clocks/[email protected].{datetime};
use golem:rpc/[email protected].2.{wit-value};
use golem:rpc/[email protected].3.{wit-value};

use host.{account-id, component-id, oplog-index, worker-id, worker-metadata};
use oplog.{oplog-entry};
Expand Down
4 changes: 2 additions & 2 deletions wit/deps/golem-1.x/golem-oplog.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package golem:[email protected].3;
package golem:[email protected].4;

/// Host interface for enumerating and searching for worker oplogs
interface oplog {
use wasi:clocks/[email protected].{datetime};
use golem:rpc/[email protected].2.{wit-value};
use golem:rpc/[email protected].3.{wit-value};

use host.{account-id, component-version, oplog-index, retry-policy, uuid, worker-id};

Expand Down
6 changes: 3 additions & 3 deletions wit/deps/golem-durability/golem-durability-1.2.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
package golem:[email protected];

interface durability {
use golem:api/[email protected].3.{persistence-level};
use golem:api/[email protected].3.{oplog-index, wrapped-function-type};
use golem:api/[email protected].4.{persistence-level};
use golem:api/[email protected].4.{oplog-index, wrapped-function-type};
use wasi:clocks/[email protected].{datetime};
use golem:rpc/[email protected].2.{value-and-type};
use golem:rpc/[email protected].3.{value-and-type};

type durable-function-type = wrapped-function-type;

Expand Down
4 changes: 2 additions & 2 deletions wit/deps/golem/golem-host.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package golem:[email protected].1;
package golem:[email protected].2;

/// The Golem host API provides low level access to Golem specific features such as promises and control over
/// the durability and transactional guarantees the executor provides.
interface host {
use golem:rpc/[email protected].2.{uri};
use golem:rpc/[email protected].3.{uri};
use wasi:clocks/[email protected].{duration};

/// An index into the persistent log storing all performed operations of a worker
Expand Down
8 changes: 7 additions & 1 deletion wit/deps/wasm-rpc/wasm-rpc.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package golem:[email protected].2;
package golem:[email protected].3;

interface types {
use wasi:clocks/[email protected].{datetime};
Expand Down Expand Up @@ -97,13 +97,19 @@ interface types {

/// Schedule invocation for later
schedule-invocation: func(scheduled-time: datetime, function-name: string, function-params: list<wit-value>) -> ();
/// Schedule invocation for later. Call cancel on the returned resource to cancel the invocation before the scheduled time.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left the old one for backwards compat as we already cut a release.
In principle we can have a more effecient implementation for the non cancellation version as it's idempotent.

(This version would be like the old code, currently I implemented it in terms of the new function to reduce code size)

schedule-cancelable-invocation: func(scheduled-time: datetime, function-name: string, function-params: list<wit-value>) -> cancellation-token;
}

resource future-invoke-result {
subscribe: func() -> pollable;
get: func() -> option<result<wit-value, rpc-error>>;
}

resource cancellation-token {
cancel: func() -> ();
}

extract-value: func(vnt: value-and-type) -> wit-value;
extract-type: func(vnt: value-and-type) -> wit-type;
}
Expand Down
Loading