Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-1837 & OCT-1838: Upgrade metrics pie chart for unused MR #383

Merged
merged 8 commits into from
Sep 2, 2024
Merged

OCT-1837 & OCT-1838: Upgrade metrics pie chart for unused MR #383

merged 8 commits into from
Sep 2, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this Aug 6, 2024
@kgarbacinski kgarbacinski marked this pull request as draft August 6, 2024 12:07
@aziolek aziolek self-requested a review August 6, 2024 13:06
@kgarbacinski
Copy link
Contributor Author

kgarbacinski commented Aug 6, 2024 •
edited
Loading

@aziolek I've changed it to a draft and need to align one thing to simplify things, will let you know when i'm done

@kgarbacinski kgarbacinski force-pushed the kacper/feat/oct-1837-metrics-pie-chart branch from 311a936 to 05e5b33 Compare August 7, 2024 12:22
@kgarbacinski kgarbacinski marked this pull request as ready for review August 7, 2024 12:26
@kgarbacinski
Copy link
Contributor Author

kgarbacinski commented Aug 7, 2024 •
edited
Loading

Haven't clicked it through the changes yet but ready for code review

paulperegud
paulperegud previously approved these changes Aug 26, 2024
View reviewed changes
aziolek
aziolek requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tactical RC waiting for ping to align FE:
=> #383 (comment)

@aziolek aziolek changed the title OCT-1837: Upgrade metics pie chart for unused MR OCT-1837 & OCT-1838: Upgrade metics pie chart for unused MR Aug 26, 2024
aziolek
aziolek previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added FE part in 8d00567. Now we need to deploy that and test.
@kgarbacinski, will you coordinate on that please?

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 26, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10562350443 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 26, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10564176839 failed 💥

housekeeper-bot
housekeeper-bot requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10564176839 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 27, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 27, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10576917506 passed 🎉

@kgarbacinski
Copy link
Contributor Author

I added FE part in 8d00567. Now we need to deploy that and test. @kgarbacinski, will you coordinate on that please?

Yes, I'll test it out asap

@housekeeper-bot housekeeper-bot temporarily deployed to uat August 28, 2024 07:46 Destroyed
@kgarbacinski
Copy link
Contributor Author

/deploy

@jmikolajczyk jmikolajczyk changed the title OCT-1837 & OCT-1838: Upgrade metics pie chart for unused MR OCT-1837 & OCT-1838: Upgrade metrics pie chart for unused MR Aug 29, 2024
@kgarbacinski kgarbacinski dismissed stale reviews from housekeeper-bot and aziolek via 0aaf45e August 29, 2024 10:24
@kgarbacinski
Copy link
Contributor Author

/deploy

@kgarbacinski kgarbacinski force-pushed the kacper/feat/oct-1837-metrics-pie-chart branch 3 times, most recently from 0d6e735 to d9e93a1 Compare August 30, 2024 12:54
@kgarbacinski kgarbacinski force-pushed the kacper/feat/oct-1837-metrics-pie-chart branch from d9e93a1 to 70dad94 Compare August 30, 2024 13:05
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Sep 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Sep 2, 2024
housekeeper-bot
housekeeper-bot approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10665479454 passed 🎉

@kgarbacinski kgarbacinski merged commit 44a889f into develop Sep 2, 2024
61 checks passed
@kgarbacinski kgarbacinski deleted the kacper/feat/oct-1837-metrics-pie-chart branch September 2, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@aziolek aziolek aziolek approved these changes

@paulperegud paulperegud paulperegud left review comments

@adam-gf adam-gf Awaiting requested review from adam-gf

Assignees

@kgarbacinski kgarbacinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgarbacinski @paulperegud @aziolek @housekeeper-bot