Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightDB Stream: fix heading and other formatting #409

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

szczys
Copy link
Collaborator

@szczys szczys commented Jun 19, 2024

  • add support for JSON syntax highlighting
  • Place headings for better readability
  • Use H2 headings for top-level sections division
  • Begin sections with text rather than bullet point
  • Add json as type for code examples for proper syntax highlighting
  • Update copy for readability

resolves https://github.com/golioth/devrel-issue-tracker/issues/48

szczys added 3 commits June 19, 2024 11:03
- Place headings for better readability
- Use H2 headings for top-level sections division
- Begin sections with text rather than bullet point
- Add `json` as type for code examples for proper syntax highlighting

Signed-off-by: Mike Szczys <[email protected]>
@szczys szczys requested review from hasheddan and ChrisGammell June 19, 2024 16:30
Copy link

Visit the preview URL for this PR (updated for commit 50eb1c4):

https://golioth-docs-dev--pr409-szczys-lightdb-strea-1ohatk7i.web.app

(expires Fri, 19 Jul 2024 16:32:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f53b02bdc98ce6f5593931ec4c339aa96bac84df

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szczys!

@szczys szczys merged commit 47e503f into main Jun 19, 2024
2 checks passed
@szczys szczys deleted the szczys/lightdb-stream-fix-headings branch June 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants