Port golioth-rs to use embassy and nrf-modem for async support. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhayes117
changed the title
|
Thank you for your contribution, @dkhayes117! We don't have any Rust experts at the moment so I wonder if I can call on a favor :) @lachlansneff @jaredwolff @alvarowolfx would you be able to review? 🙏 |
add at-command parse error back to error.rs fix readme typo
|
@dkhayes117 @beriberikix I'll try to take a look this weekend if I can make the time! No promises though! |
…, one with observers.
…version, test software with modem firmware 1.3.4.
|
@hasheddan would you be interested/able to review? |
hasheddan
reviewed
Jun 13, 2023
There was a problem hiding this comment.
@beriberikix would love to! And good to see you here @dkhayes117 :)
|
I think I will convert this to a draft because I'd like to try and get coap observers working first. I'm recording youtube videos that walk you through setup and use, so anyone can get started. Feel free to poke around in the meantime. |
…date embassy-executor to v0.2. Update README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async support for the nRF9160 SiP. Supports writing to LightDB State and Stream, and reading from LightDB State. Reading from LightDB Stream has not been tested. Thanks!