Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore archived repos #52

Closed
wants to merge 4 commits into from
Closed

Ignore archived repos #52

wants to merge 4 commits into from

Conversation

ianling
Copy link

@ianling ianling commented Feb 2, 2022

Ignores archived repos when creating releases to make things go slightly faster.

	if count == 0 {
		return nil, nil
	}

... is a drive-by that prevents a crash due to gosuri/uiprogress#47 when no repos are found for a particular user/organization.

@dan9186
Copy link
Member

dan9186 commented Feb 2, 2022

I know they're small, but please science one thing at a time. One for the bug, and one for the performance boost. I'm not particularly interested in taking on any formatting changes that fmt or the linter doesn't care about.

@ianling
Copy link
Author

ianling commented Feb 3, 2022

Split everything up into separate commits @dan9186

The formatting change does seem to be coming from go fmt so I left it in, but I can drop the commit if you don't want it.

@ianling ianling closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants