Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the flyout for compatibility with the new flyout API #209

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

gonfunko
Copy link
Owner

@gonfunko gonfunko commented Oct 7, 2024

This PR updates the continuous flyout subclass for compatibility with the new flyout API. Additionally:

Several methods have been mostly cribbed from the plugin's implementation with slight changes for API compatibility; ultimately these will be upstreamed into the plugin and should then be removed here in favor of the superclass implementation.

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please file a bug and add TODO(bugNum) in the appropriate places for the follow-up work you have in mind.

@gonfunko
Copy link
Owner Author

gonfunko commented Oct 7, 2024

Opened #211 and google/blockly-samples#2464 to track and added comments to the relevant methods.

@gonfunko gonfunko merged commit 7ce9991 into modern-blockly Oct 7, 2024
1 check passed
@gonfunko gonfunko deleted the flyout-compat branch October 7, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is too much space between blocks and checkboxes in the flyout
2 participants