fix: fix issue that caused the number/string input in the custom block editor to display square corners #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editor to have square corners
gonfunko
force-pushed
the
rounded-editor
branch
from
1529622 to
514a3cc
Compare
rachel-fenichel
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #202. The superclass calculates rounded corners based on its height, which was ~1px when a new string/number field is added to a custom block, because it was sized before its host block had fully rendered. On subsequent focus events, the field did have rounded corners as expected. Now, we wait for the next render cycle before showing the editor so that the metrics will always be calculated correctly.