refactor: migrate scratch-blocks to Typescript #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icator_label_flyout_inflater.ts
…_flyout_inflater.ts
1 task
|
@cwillisf let me know if this all looks good to you! |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the scratch-blocks codebase to Typescript, and cleans up/modernizes a few files. Two files are unconverted:
layout_()on VerticalFlyout (bypassing its parent class), which is a protected method. Although it is a subclass, because its parent class (ContinuousFlyout) is JS, TS doesn't know this and complains. This is a temporary workaround that can be removed once the Continuous Toolbox plugin is updated to account for the new flyout API, at which point this file can be converted.ISelectablerequires a publicworkspacefield.CommentView, the superclass ofScratchCommentBubble, has aworkspacefield, but it's private, soCommentViewcan't make it public to implement the interface. This will either need to be made public in core, or have the field in core named something else.