fix: load CSS and fix up UI appearance #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
This is much cleaner thank you! I think we still need to pull at this string a bit more to figure out where we should be using CSS and where we should be using themes. But this fixes the monkey patching which is great.
I didn't look super closely at the CSS, but a skim looked good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR loads Scratch's CSS and matches Scratch's scrollbar dimensions. It also exports colors as CSS variables, and updates the CSS to reference these rather than find-and-replacing in an overridden inject().