-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PROMO server-side validation route #2318
Open
m-amaya
wants to merge
8
commits into
master
Choose a base branch
from
2318-promo-route-validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b946aa3
added promo validation route
67e6c37
added promo errors
5ad41d0
added validation controller
fd6364d
cleaned up validation controller
16af250
Fix indentation
jrf0110 754d86b
Fix indentation
jrf0110 d141ae3
fixed merge conflicts
m-amaya e83993c
Merge branch '2318-promo-route-validation' of https://github.com/good…
m-amaya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
module.exports = require('./orders'); | ||
module.exports.orderItems = require('./order-items'); | ||
module.exports.notifications = require('./notifications'); | ||
module.exports.deliveryServices = require('./delivery-services'); | ||
module.exports.deliveryServices = require('./delivery-services'); | ||
module.exports.promos = require('./promos'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
var db = require('../../db'); | ||
var errors = require('../../errors'); | ||
|
||
module.exports.validate = function(req, res) { | ||
const promo_code = req.body.promo_code; | ||
const order_id = req.params.oid; | ||
|
||
var where = { promo_code }; | ||
|
||
db.promos.findOne( where, (err, result) => { | ||
|
||
if( !result ) { | ||
res.error( errors.promos.DOES_NOT_EXIST ); | ||
return; | ||
} | ||
|
||
var where = { promo_id: promo_code, order_id }; | ||
|
||
db.promos_applied.findOne( where, (err, result) => { | ||
|
||
if( result ) { | ||
res.error( errors.promos.ALREADY_APPLIED ); | ||
return; | ||
} | ||
|
||
res.sendStatus(200); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the request is successful, and but there's no content to return, use the status code |
||
}); | ||
|
||
}); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works nicely, but I think we can make it even better by consolidating the two database calls into one by adding a join: