Plot global plasma parameters vs time #617
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
… all sim tests still passed before
| figure_size_factor=5, | ||
| title_fontsize=12, | ||
| axes=( | ||
| # For chi, set histogram percentile for y-axis upper limit, due to |
There was a problem hiding this comment.
This comment can be removed
| cols=3, | ||
| tick_fontsize=8, | ||
| axes_fontsize=8, | ||
| default_legend_fontsize=7, |
There was a problem hiding this comment.
looking at the example plot pasted in the PR, it feels like either all fontsizes can be increased or the figure_size_factor reduced. Should experiment with that a bit more and find more optimal values for clear plots
There was a problem hiding this comment.
Done 4929853.
The example plot was updated too.
|
Looks great, thanks, will bring it in |
There was a problem hiding this comment.
A few minor changes have been done on our end before merging, noticed by the linter, and will be visible in the merge commit.
No action needed from you, but mentioning for visibility.
- The tuple typehint is not necessary for a single output in the q95 function. Could just be array_typing.ScalarFloat.
2. There were a couple of stray comments removed, related to IPython.embed(sorry, that wasn't true, confusion on my end) - Various formatting issues raised by the linter. I recommended installing and embedding pylint within your VScode to catch these ahead of time.
|
Merged with 2af8b67 |
This PR adds a few more plasma parameters to be calculated by the post-processing script and makes a new plot config to plot them vs time.
New parameters in post-processing:
It would be nice to have an option to remove a time slider for plots that show parameters only vs time.
Issue open: #616
Example of the plot output with
torax/plotting/configs/global_params_plot_config.py: