Implemented the Support Application Default Credentials #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated search-grounding.ts file integrates Application Default Credentials (ADC) support for authenticating Google Search API requests. It includes:
ADC Authentication: A utility function (getAuthenticatedClient) fetches credentials using ADC or falls back to environment variables if ADC is unavailable.
Type Safety: Explicit type handling ensures the authenticated client is either a JWT or OAuth2Client.
Error Handling: Proper error handling is added for failed authentication.
Service Class: A GoogleSearchRetrievalService class initializes the authenticated client and provides a method (fetchData) to interact with the Google Search API.
Linting Fixes: Addressed ESLint errors by ensuring promises are handled, adding return types, and avoiding the any type.