Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Prefer setup_check.sh over manual config #218

Merged
merged 3 commits into from
Mar 5, 2025
Merged

[Infra] Prefer setup_check.sh over manual config #218

merged 3 commits into from
Mar 5, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 5, 2025 •
edited
Loading

This simplifies things by getting clang-format from the firebase-ios-sdk checkout during CI rather than from this repo.

Corresponding GoogleDataTransport PR: google/GoogleDataTransport#157

@ncooke3 ncooke3 mentioned this pull request Mar 5, 2025
Merged
@ncooke3 ncooke3 enabled auto-merge (squash) March 5, 2025 21:33
@ncooke3 ncooke3 requested review from paulb777 and andrewheard March 5, 2025 21:33
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from ? (ba8e711) to 0.14% (e9fec24) by ?.

    22 individual files with coverage change

    FilenameBase (ba8e711)Merge (e9fec24)Diff
    GULAppDelegateSwizzler.m?0.00%?
    GULAppEnvironmentUtil.m?3.42%?
    GULKeychainStorage.m?0.00%?
    GULKeychainUtils.m?0.00%?
    GULLogger.m?0.00%?
    GULMutableDictionary.m?0.00%?
    GULNetwork.m?0.00%?
    GULNetworkInfo.m?0.00%?
    GULNetworkURLSession.m?0.00%?
    GULNSData+zlib.m?0.00%?
    GULReachabilityChecker.m?0.00%?
    GULRuntimeClassDiff.m?0.00%?
    GULRuntimeClassSnapshot.m?0.00%?
    GULRuntimeDiff.m?0.00%?
    GULRuntimeSnapshot.m?0.00%?
    GULRuntimeStateHelper.m?0.00%?
    GULSceneDelegateSwizzler.m?0.00%?
    GULSwizzler+Unswizzle.m?0.00%?
    GULSwizzler.m?0.00%?
    GULSwizzlingCache.m?0.00%?
    GULUserDefaults.m?0.00%?
    IsAppEncrypted.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Db7nc1uZKe.html

@ncooke3 ncooke3 mentioned this pull request Mar 5, 2025
Merged
@ncooke3 ncooke3 merged commit 670fc1c into main Mar 5, 2025
21 checks passed
@ncooke3 ncooke3 deleted the ncooke3-patch-1 branch March 5, 2025 21:40
andrewheard
andrewheard reviewed Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick! This will make it easier to keep up with the clang-format updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard left review comments

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard