Skip to content

Commit

Permalink
Fixes incorrect error code for vendor U2F (#707)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaczmarczyck authored Oct 1, 2024
1 parent 2d970fd commit c5b08fd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions libraries/opensk/src/ctap/ctap1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,7 @@ impl Ctap1Command {
// U2F raw message format specification (version 20170411) section 6.3
U2fCommand::Version => Ok(Vec::<u8>::from(super::U2F_VERSION_STRING)),

// TODO: should we return an error instead such as SW_INS_NOT_SUPPORTED?
U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_SUCCESS),
U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_INS_INVALID),
}
}

Expand Down

0 comments on commit c5b08fd

Please sign in to comment.