Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venv for Python setup #653

Merged
merged 2 commits into from
Nov 7, 2023
Merged

venv for Python setup #653

merged 2 commits into from
Nov 7, 2023

Conversation

kaczmarczyck
Copy link
Collaborator

Makes the Python part of OpenSK's installer independent of system changes.

Some missing Python packets for testing are added to the requirements.

@kaczmarczyck kaczmarczyck requested a review from ia0 November 6, 2023 15:51
@coveralls
Copy link

coveralls commented Nov 6, 2023

Coverage Status

coverage: 96.317% (-0.03%) from 96.349%
when pulling 1a68b48 on kaczmarczyck:py-setup
into 67e3d46 on google:develop.

Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deploy.py Outdated Show resolved Hide resolved
tools/configure.py Outdated Show resolved Hide resolved
tools/run_pylint.sh Outdated Show resolved Hide resolved
@kaczmarczyck kaczmarczyck requested a review from ia0 November 6, 2023 19:23
@kaczmarczyck kaczmarczyck merged commit 7781027 into google:develop Nov 7, 2023
25 checks passed
@kaczmarczyck kaczmarczyck deleted the py-setup branch November 7, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup script can't install pip packages to the user's environment on Arch Linux
3 participants