Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps the Rust toolchain version #687

Merged
merged 1 commit into from
May 27, 2024

Conversation

kaczmarczyck
Copy link
Collaborator

This has a few useful effects:

  • Hopefully fixes a recent OSS-Fuzz failure to compile.
  • Decreases binary size by 0.8 kB.
  • Fixes a warning by cargo audit.

We also bump our minimum supported Rust version to what it actually is. We had an API call for BTreeSet that needs Rust 1.66. If you use an older version, you have to patch OpenSK and replace pop_first with an iterator that takes the first element, like we did before pop_first was available.

This has a few useful effects:

- Hopefully fixes a recent OSS-Fuzz failure to compile.
- Decreases binary size by 0.8 kB.
- Fixes a warning by `cargo audit`.

We also bump our minimum supported Rust version to what it actually is.
We had an API call for `BTreeSet` that needs Rust 1.66. If you use an
older version, you have to patch OpenSK and replace `pop_first` with an
iterator that takes the first element, like we did before `pop_first`
was available.
@kaczmarczyck kaczmarczyck requested a review from ia0 May 27, 2024 10:45
@coveralls
Copy link

Coverage Status

coverage: 97.14%. remained the same
when pulling 93825ac on kaczmarczyck:version-bump
into 119cc21 on google:develop.

@kaczmarczyck kaczmarczyck merged commit 8a0ee9d into google:develop May 27, 2024
9 checks passed
@kaczmarczyck kaczmarczyck deleted the version-bump branch May 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants