Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openssl dependency #694

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

kaczmarczyck
Copy link
Collaborator

Fixes a vulnerable package found by cargo audit.

@kaczmarczyck kaczmarczyck requested a review from ia0 July 23, 2024 09:55
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we get a dependabot PR for this? We have a dependabot alert. Is it because of those lines?

allow:
- dependency-type: "direct"
ignore:
# Filter out semver patches updates to reduce the frequency of updates
- dependency-name: "*"
update-types: ["version-update:semver-patch"]

This dependabot configuration applies to both version updates and security updates. Not sure if there's a way to fix this, other than removing those lines.

Issue introduced by #683.

@kaczmarczyck
Copy link
Collaborator Author

We got one on 2.1, I think it's on the default branch only.

@kaczmarczyck kaczmarczyck merged commit d624558 into google:develop Jul 23, 2024
9 checks passed
@kaczmarczyck kaczmarczyck deleted the fix-vuln branch July 23, 2024 11:43
@ia0
Copy link
Member

ia0 commented Jul 23, 2024

We got one on 2.1, I think it's on the default branch only.

I'm still failing to find that PR :D but it would make sense that it's only the default branch. Can you give me a link to that dependabot PR for openssl on the 2.1 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants