Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

[Translate ru] web-components/customelements #8372

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gitlocalize-app[bot]
Copy link
Contributor

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@WebFundBot
Copy link

Whoops!

There were 2 critical errors that broke the build and prevented it from being automatically deployed.

There were 7 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

ERRORS
src/content/ru/fundamentals/web-components/customelements.md - Unable to find specified 'book_path': "/web/fundamentals/_book.yaml"
src/content/ru/fundamentals/web-components/customelements.md - Unable to find specified 'project_path': "/web/fundamentals/_project.yaml"

WARNINGS
src/content/ru/fundamentals/web-components/customelements.md#L492 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L597 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L643 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L688 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1078 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1081 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1078 - Common typo found: 'node' Should it be 'Node'?

@ilyaspiridonov
Copy link
Contributor

@googlebot I consent

@ilyaspiridonov
Copy link
Contributor

@googlebot I consent.

Copy link
Member

@petele petele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that the style matches the existing. I see several places where the markdown doesn't seem correct (spaces in anchors, etc)

@@ -0,0 +1,1127 @@
project_path: "/web/fundamentals/_project.yaml"
book_path: "/web/fundamentals/_book.yaml"
description: Пользовательские элементы позволяют разработчикам определять новые HTML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should not span two lines.


let promises = [...undefinedButtons].map(socialButton => {
return customElements.whenDefined(socialButton.localName);
));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #8938, should be:

})

Base automatically changed from master to main January 28, 2021 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants