-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Translate ru] web-components/customelements #8372
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Whoops! There were 2 critical errors that broke the build and prevented it from being automatically deployed. There were 7 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed. ERRORS WARNINGS |
@googlebot I consent |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm that the style matches the existing. I see several places where the markdown doesn't seem correct (spaces in anchors, etc)
@@ -0,0 +1,1127 @@ | |||
project_path: "/web/fundamentals/_project.yaml" | |||
book_path: "/web/fundamentals/_book.yaml" | |||
description: Пользовательские элементы позволяют разработчикам определять новые HTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description should not span two lines.
|
||
let promises = [...undefinedButtons].map(socialButton => { | ||
return customElements.whenDefined(socialButton.localName); | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #8938, should be:
})
Check out a review request at GitLocalize