Set the stack alignment to the size of the underlying vector type for x86 microkernel builds.
#7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_719315622
branch
6 times, most recently
from
87c2b30 to
898c95b
Compare
copybara-service
bot
changed the title
x86 microkernel builds.x86 microkernel builds.
copybara-service
bot
force-pushed
the
test_719315622
branch
2 times, most recently
from
1d4f7fe to
ef7806b
Compare
… `x86` microkernel builds. This makes register spilling a _lot_ faster in some cases where the stack pointer was not aligned. Note that the baseline stack alignment depends on the size and alignment of the underlying call stack and may therefore vary significantly from one type of benchmark to another. PiperOrigin-RevId: 720461988
copybara-service
bot
force-pushed
the
test_719315622
branch
from
ef7806b to
41dd468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the stack alignment to the size of the underlying vector type for
x86microkernel builds.This makes register spilling a lot faster in some cases where the stack pointer was not aligned.
Note that the baseline stack alignment depends on the size and alignment of the underlying call stack and may therefore vary significantly from one type of benchmark to another.