-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stitching Upload Components to support multiple Upload Strategies #2286
Merged
omarismail94
merged 9 commits into
google:master
from
anchita-g:upload-components-stitch
Dec 15, 2023
Merged
Stitching Upload Components to support multiple Upload Strategies #2286
omarismail94
merged 9 commits into
google:master
from
anchita-g:upload-components-stitch
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine/src/main/java/com/google/android/fhir/sync/upload/UploadStrategy.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/patch/PatchGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/patch/PatchGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/patch/PatchGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/request/UploadRequestGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/request/UrlRequestGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
omarismail94
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
One of the PRs to fix #760
Description
We connect the four components:
LocalChangeFetcher
,PatchGenerator
,RequestGenerator
andResourceConsolidator
for upload sync to work according to any type ofUploadStrategy
provided.Since we have not implemented al the types of the components, with the implementations we have so far, we can only use a few
UploadStrategy
.The connection of the components is mainly established by maintaining a mapping of the
LocalChanges
to the respective outputs in each stage. For example,PatchGenerator
is expected to outputPatch
as well as the respective list ofLocalChange
from which eachPatch
was generated.For
RequestGenerator
, using the mappedPatch
forLocalChanges
, the request generator should output theUploadRequest
generated as well as theLocalChanges
of thePatches
from which this request was generated.For
BundleRequestGenerator
, the mapping to theLocalChanges
is at the level of each entry in theBundleRequest
.This would help in the
ResourceConsolidator
where in eachBundleEntry
is like an independent request being executed with its own corresponding response, hence, we would need to know theLocalChanges
which result in that particular BundleEntry request.Alternative(s) considered
NA
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.