Highlight form fields that fail validation when submit button is clicked

[rahulmalhotra]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2681

Description
This change removes forceValidation = false assignment in the QuestionnaireViewModel which was re-rendering the current patient edit screen without validation results.

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[rahulmalhotra]

Hi @jingtang10 as per our discussion, I removed forceValidation attribute and used modifiedQuestionnaireResponseItemSet instead. Please take a look and let me know if this looks good? I tested it locally by running the demo app and it's working fine.

[rahulmalhotra]

Hi @jingtang10 I checked for the next/previous case. It depends on entry mode of questionnaire. Please take a look at my findings below:

1. If the questionnaire has multiple pages, as we click the Next button, its going to validate the fields on the current page only if the questionnaire as an entry mode of prior-edit or sequential code ref
2. If there is no entry mode defined in the questionnaire, the default entry mode will be random and in this case, no validation error will throw on clicking the next button. However, as we submit the form at the last page, the popup will appear showing list of required fields which are not filled (even if those are on the previous page).

Please let me know how should we proceed here.

[jingtang10]

@LZRS can you please take a look at this PR and test it?

[LZRS]

I've tested this out with a paginated questionnaire that has an entry mode of prior-edit and also has a repeat group questionnaire item, and it looks good 👍

It validates the current page correctly and prevents one from navigating to the next page

[MJ1998]

LGTM

[MJ1998]

@rahulmalhotra can you update the branch ? I have enabled auto-merge.