🌱 Bump dtolnay/rust-toolchain (#43) #38
cocuh
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
12 warnings
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L438
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:438:18
|
438 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/assertions/map.rs#L424
warning: useless use of `format!`
--> src/assertions/map.rs:424:17
|
424 | format!("expected to not contain additional entries"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L404
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:404:18
|
404 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L285
warning: unneeded `return` statement
--> src/assertions/map.rs:285:9
|
285 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L438
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:438:18
|
438 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/assertions/map.rs#L424
warning: useless use of `format!`
--> src/assertions/map.rs:424:17
|
424 | format!("expected to not contain additional entries"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L404
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:404:18
|
404 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L285
warning: unneeded `return` statement
--> src/assertions/map.rs:285:9
|
285 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
285 - return self.new_result().do_ok();
285 + self.new_result().do_ok()
|
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
SARIF file
Expired
|
74.9 KB |
|