warning: useless use of `format!` --> src/base.rs:405:47 | 405 | ... .map(|el| format!("{}", el)) | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: useless use of `format!` --> src/base.rs:387:44 | 387 | let formatted_values = format!( | ____________________________________________^ 388 | | "{}", 389 | | if use_multiline_output { 390 | | let elements = values ... | 409 | | } 410 | | ); | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format help: consider using `.to_string()` | 387 ~ let formatted_values = (if use_multiline_output { 388 + let elements = values 389 + .iter() 390 + .map(|el| format!(" - {}", el)) 391 + .collect::<Vec<_>>() 392 + .join("\n"); 393 + if values_size > 0 { 394 + format!("[\n{}\n]", elements) 395 + } else { 396 + "[]".to_string() 397 + } 398 + } else { 399 + format!( 400 + "[ {} ]", 401 + values 402 + .iter() 403 + .map(|el| format!("{}", el)) 404 + .collect::<Vec<_>>() 405 + .join(", ") 406 + ) 407 ~ }).to_string(); |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/assertions/map.rs:438:18 | 438 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref

warning: useless use of `format!` --> src/assertions/map.rs:424:17 | 424 | format!("expected to not contain additional entries"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/assertions/map.rs:404:18 | 404 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `#[warn(clippy::into_iter_on_ref)]` on by default

warning: unneeded `return` statement --> src/assertions/map.rs:285:9 | 285 | return self.new_result().do_ok(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 285 - return self.new_result().do_ok(); 285 + self.new_result().do_ok() |

warning: call to `.borrow()` on a reference in this situation does nothing --> src/assertions/map.rs:206:58 | 206 | format!("{:?}", actual_value.unwrap().borrow()), | ^^^^^^^^^ help: remove this redundant call | = note: the type `V` does not implement `Borrow`, so calling `borrow` on `&V` copies the reference, which does not do anything and can be removed

warning: call to `.borrow()` on a reference in this situation does nothing --> src/assertions/iterator.rs:515:48 | 515 | if actual_iter.clone().any(|x| x.eq(element.borrow())) { | ^^^^^^^^^ help: remove this redundant call | = note: the type `T` does not implement `Borrow`, so calling `borrow` on `&T` copies the reference, which does not do anything and can be removed

warning: call to `.borrow()` on a reference in this situation does nothing --> src/assertions/iterator.rs:494:48 | 494 | if actual_iter.clone().any(|x| x.eq(element.borrow())) { | ^^^^^^^^^ help: remove this redundant call | = note: the type `T` does not implement `Borrow`, so calling `borrow` on `&T` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default

warning: useless use of `format!` --> src/base.rs:405:47 | 405 | ... .map(|el| format!("{}", el)) | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: useless use of `format!` --> src/base.rs:387:44 | 387 | let formatted_values = format!( | ____________________________________________^ 388 | | "{}", 389 | | if use_multiline_output { 390 | | let elements = values ... | 409 | | } 410 | | ); | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format help: consider using `.to_string()` | 387 ~ let formatted_values = (if use_multiline_output { 388 + let elements = values 389 + .iter() 390 + .map(|el| format!(" - {}", el)) 391 + .collect::<Vec<_>>() 392 + .join("\n"); 393 + if values_size > 0 { 394 + format!("[\n{}\n]", elements) 395 + } else { 396 + "[]".to_string() 397 + } 398 + } else { 399 + format!( 400 + "[ {} ]", 401 + values 402 + .iter() 403 + .map(|el| format!("{}", el)) 404 + .collect::<Vec<_>>() 405 + .join(", ") 406 + ) 407 ~ }).to_string(); |

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/assertions/map.rs:438:18 | 438 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref

warning: useless use of `format!` --> src/assertions/map.rs:424:17 | 424 | format!("expected to not contain additional entries"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> src/assertions/map.rs:404:18 | 404 | .into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `#[warn(clippy::into_iter_on_ref)]` on by default

warning: unneeded `return` statement --> src/assertions/map.rs:285:9 | 285 | return self.new_result().do_ok(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 285 - return self.new_result().do_ok(); 285 + self.new_result().do_ok() |

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/