Added support for key order comparison in map diff (#75) #97
cocuhAnnotations
16 warnings
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L434
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:434:18
|
434 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/assertions/map.rs#L420
warning: useless use of `format!`
--> src/assertions/map.rs:420:17
|
420 | format!("expected to not contain additional entries"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L400
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:400:18
|
400 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L285
warning: unneeded `return` statement
--> src/assertions/map.rs:285:9
|
285 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
285 - return self.new_result().do_ok();
285 + self.new_result().do_ok()
|
|
|
field `key_order_comparison` is never read:
src/diff.rs#L34
warning: field `key_order_comparison` is never read
--> src/diff.rs:34:20
|
29 | pub(crate) struct MapComparison<K: Eq + Hash + Debug, V: PartialEq + Debug> {
| ------------- field in this struct
...
34 | pub(crate) key_order_comparison: Option<SequenceComparison<K>>,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L434
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:434:18
|
434 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/assertions/map.rs#L420
warning: useless use of `format!`
--> src/assertions/map.rs:420:17
|
420 | format!("expected to not contain additional entries"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"expected to not contain additional entries".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L400
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:400:18
|
400 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L285
warning: unneeded `return` statement
--> src/assertions/map.rs:285:9
|
285 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
285 - return self.new_result().do_ok();
285 + self.new_result().do_ok()
|
|
|
field `key_order_comparison` is never read:
src/diff.rs#L34
warning: field `key_order_comparison` is never read
--> src/diff.rs:34:20
|
29 | pub(crate) struct MapComparison<K: Eq + Hash + Debug, V: PartialEq + Debug> {
| ------------- field in this struct
...
34 | pub(crate) key_order_comparison: Option<SequenceComparison<K>>,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
clippy / nightly
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy / stable
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|