🌱 Bump github/codeql-action from 3.23.1 to 3.24.7 #124
dependabot[bot]Annotations
34 warnings
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap`:
src/diff.rs#L118
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap`
--> src/diff.rs:118:18
|
118 | self.into_iter().collect()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`:
src/diff.rs#L92
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`
--> src/diff.rs:92:18
|
92 | self.into_iter().collect()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet`:
src/assertions/set.rs#L243
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet`
--> src/assertions/set.rs:243:14
|
243 | self.into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L242
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:242:13
|
242 | fn iter<'a>(&'a self) -> Self::It<'a> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
242 - fn iter<'a>(&'a self) -> Self::It<'a> {
242 + fn iter(&self) -> Self::It<'_> {
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet`:
src/assertions/set.rs#L235
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet`
--> src/assertions/set.rs:235:14
|
235 | self.into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L234
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:234:13
|
234 | fn iter<'a>(&'a self) -> Self::It<'a> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
234 - fn iter<'a>(&'a self) -> Self::It<'a> {
234 + fn iter(&self) -> Self::It<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L222
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:222:13
|
222 | fn iter<'a>(&'a self) -> Self::It<'a>;
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
222 - fn iter<'a>(&'a self) -> Self::It<'a>;
222 + fn iter(&self) -> Self::It<'_>;
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L562
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:562:18
|
562 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L528
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:528:18
|
528 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L344
warning: unneeded `return` statement
--> src/assertions/map.rs:344:9
|
344 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
344 - return self.new_result().do_ok();
344 + self.new_result().do_ok()
|
|
|
bound is defined in more than one place:
src/assertions/map.rs#L325
warning: bound is defined in more than one place
--> src/assertions/map.rs:325:29
|
325 | fn does_not_contain_any<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^
...
330 | BM: Borrow<OML> + 'a,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
|
bound is defined in more than one place:
src/assertions/map.rs#L325
warning: bound is defined in more than one place
--> src/assertions/map.rs:325:37
|
325 | fn does_not_contain_any<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^^
...
329 | OML: MapLike<K, V> + 'a,
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
|
bound is defined in more than one place:
src/assertions/map.rs#L100
warning: bound is defined in more than one place
--> src/assertions/map.rs:100:29
|
100 | fn does_not_contain_any<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^
...
105 | BM: Borrow<OML> + 'a;
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
|
bound is defined in more than one place:
src/assertions/map.rs#L100
warning: bound is defined in more than one place
--> src/assertions/map.rs:100:37
|
100 | fn does_not_contain_any<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^^
...
104 | OML: MapLike<K, V> + 'a,
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
|
bound is defined in more than one place:
src/assertions/map.rs#L92
warning: bound is defined in more than one place
--> src/assertions/map.rs:92:26
|
92 | fn contains_at_least<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^
...
97 | BM: Borrow<OML> + 'a;
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
|
|
bound is defined in more than one place:
src/assertions/map.rs#L92
warning: bound is defined in more than one place
--> src/assertions/map.rs:92:34
|
92 | fn contains_at_least<BM: 'a, OML: 'a>(&self, expected: BM) -> R
| ^^^
...
96 | OML: MapLike<K, V> + 'a,
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
clippy / nightly
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clippy / nightly
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap`:
src/diff.rs#L118
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashMap`
--> src/diff.rs:118:18
|
118 | self.into_iter().collect()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`:
src/diff.rs#L92
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`
--> src/diff.rs:92:18
|
92 | self.into_iter().collect()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
useless use of `format!`:
src/base.rs#L405
warning: useless use of `format!`
--> src/base.rs:405:47
|
405 | ... .map(|el| format!("{}", el))
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `el.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
src/base.rs#L387
warning: useless use of `format!`
--> src/base.rs:387:44
|
387 | let formatted_values = format!(
| ____________________________________________^
388 | | "{}",
389 | | if use_multiline_output {
390 | | let elements = values
... |
409 | | }
410 | | );
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
help: consider using `.to_string()`
|
387 ~ let formatted_values = (if use_multiline_output {
388 + let elements = values
389 + .iter()
390 + .map(|el| format!(" - {}", el))
391 + .collect::<Vec<_>>()
392 + .join("\n");
393 + if values_size > 0 {
394 + format!("[\n{}\n]", elements)
395 + } else {
396 + "[]".to_string()
397 + }
398 + } else {
399 + format!(
400 + "[ {} ]",
401 + values
402 + .iter()
403 + .map(|el| format!("{}", el))
404 + .collect::<Vec<_>>()
405 + .join(", ")
406 + )
407 ~ }).to_string();
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet`:
src/assertions/set.rs#L243
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeSet`
--> src/assertions/set.rs:243:14
|
243 | self.into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L242
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:242:13
|
242 | fn iter<'a>(&'a self) -> Self::It<'a> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
242 - fn iter<'a>(&'a self) -> Self::It<'a> {
242 + fn iter(&self) -> Self::It<'_> {
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet`:
src/assertions/set.rs#L235
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet`
--> src/assertions/set.rs:235:14
|
235 | self.into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L234
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:234:13
|
234 | fn iter<'a>(&'a self) -> Self::It<'a> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
234 - fn iter<'a>(&'a self) -> Self::It<'a> {
234 + fn iter(&self) -> Self::It<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
src/assertions/set.rs#L222
warning: the following explicit lifetimes could be elided: 'a
--> src/assertions/set.rs:222:13
|
222 | fn iter<'a>(&'a self) -> Self::It<'a>;
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
222 - fn iter<'a>(&'a self) -> Self::It<'a>;
222 + fn iter(&self) -> Self::It<'_>;
|
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L562
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:562:18
|
562 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
|
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
src/assertions/map.rs#L528
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> src/assertions/map.rs:528:18
|
528 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
|
unneeded `return` statement:
src/assertions/map.rs#L344
warning: unneeded `return` statement
--> src/assertions/map.rs:344:9
|
344 | return self.new_result().do_ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
344 - return self.new_result().do_ok();
344 + self.new_result().do_ok()
|
|
|
clippy / stable
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clippy / stable
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|