feat: Make cursor arrow keys behave as per #129 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify LineCursor so that movement via arrow keys behaves as described in #129.
cpcallen
requested review from
rachel-fenichel
and removed request for
a team
rachel-fenichel
approved these changes
Jan 10, 2025
|
This change undid my kludge to fix #67 |
|
Filed google/blockly#8739 for issue with missing marker on full-block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
LineCursorso that movement via arrow keys behaves as described in #129, specifically:Part of #129.
Note that when using the zelos renderer, if you navigate to a whole-block field the cursor temporarily disappears. This is due to (what I will claim is) a bug in marker rendering in Blockly. Rendering works as expected in geras and thrasos.